Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XML tag using def #921

Merged
merged 22 commits into from
Dec 6, 2024
Merged

XML tag using def #921

merged 22 commits into from
Dec 6, 2024

Conversation

pelikhan
Copy link
Member

@pelikhan pelikhan commented Dec 6, 2024

LLMs have been trained to support xml tags. This changes adds support for those.


  • Removed redundant model specifications across various scripts (UI to change token #23)

    • Image-related scripts now use vision model reference
    • Documentation and presentation slides updated to reflect this change
  • Consolidated duplicate logic for processing images (prompt should be opened in 50% to enable dev flow #24)

    • Created common utility function to handle image definition (defImages)
    • Reduced repetition in script definitions across different modules
  • Updated default behavior of scripts to check if file array is empty before proceeding with execution

    • Added conditional checks to handle edge cases, ensuring robust operation
    • Improved error handling and user feedback mechanisms

generated by pr-describe

Copy link

github-actions bot commented Dec 6, 2024

LGTM 🚀

The changes in this pull request look good to me. The addition of the FenceFormat type and related options seems well-thought-out and should help with rendering code sections consistently across different templates. The updates to the model options also make sense.

Overall, these changes improve the flexibility and functionality of the template system without introducing any obvious functional issues.

generated by pr-review

Copy link

github-actions bot commented Dec 6, 2024

Investigator report

(view differences in changes made between the latest successful commit and the run that failed)
, test results

generated by gai

Copy link

github-actions bot commented Dec 6, 2024

Based on the provided workflow configuration, the job 'build' is triggered by several events and includes a matrix strategy for different Node.js versions. The steps in the job involve checking out code, setting up Node.js, running Yarn install, type checking, compiling, linting, packaging VSCode, compiling system scripts, and running unit tests.

To identify the root cause of failure for job 'build (20)', we need the SHA or head_sha value from the most recent successful run for that job. Please provide this information so I can assist you further.

generated by github-agent

Copy link

github-actions bot commented Dec 6, 2024

{
  "response": "<error>Tool not found</error>"
}

generated by github-one

@pelikhan pelikhan merged commit 4a463e0 into main Dec 6, 2024
7 of 9 checks passed
@pelikhan pelikhan deleted the xmlfence branch December 6, 2024 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant